Skip to content

[REST API] Delete application password on switch store #8513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2023
Merged

[REST API] Delete application password on switch store #8513

merged 2 commits into from
Jan 2, 2023

Conversation

@selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Jan 2, 2023 •
edited
Loading

Closes: #8496

Description

  • Deletes the application password upon switching store.
  • Adds unit tests to verify that the delete application password process is invoked properly.

Testing instructions

  • We currently don't have a way to switch stores when authenticated using an application password.
  • CI passing should be enough.

Screenshots

NA

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@selanthiraiyan selanthiraiyan added type: task An internally driven task. feature: login Related to any part of the log in or sign in flow, or authentication. labels Jan 2, 2023
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 2, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8513-1aadd31 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@selanthiraiyan selanthiraiyan changed the title Feat/8496 delete on switch store [REST API] Delete application password on switch store Jan 2, 2023
@selanthiraiyan selanthiraiyan mentioned this pull request Jan 2, 2023
Closed
2 tasks
@selanthiraiyan selanthiraiyan added this to the 11.8 milestone Jan 2, 2023
@selanthiraiyan selanthiraiyan marked this pull request as ready for review January 2, 2023 08:39
@itsmeichigo itsmeichigo self-assigned this Jan 2, 2023
itsmeichigo
itsmeichigo approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@selanthiraiyan selanthiraiyan merged commit 6286e72 into feat/8496-delete-on-logout Jan 2, 2023
@selanthiraiyan selanthiraiyan deleted the feat/8496-delete-on-switch-store branch January 2, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

@jaclync jaclync Awaiting requested review from jaclync

Assignees

@itsmeichigo itsmeichigo

Labels

feature: login Related to any part of the log in or sign in flow, or authentication. type: task An internally driven task.

Projects

None yet

Milestone

11.8

Development

Successfully merging this pull request may close these issues.

4 participants

@selanthiraiyan @wpmobilebot @itsmeichigo